-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix eventListener binding to avoid creating new functions #11
Comments
I've decided against this. Will reconsider it when auditing the framework later |
This has been brought to my attention again. A fix is in the works |
brought to my attention by a reddit comment
|
I'm going to table this for now |
I'm going to reopen this issue and investigate using a weakmap for the binding the methods. I will not be using the |
I believe the option is to use experimental syntax for component classes. I will wait for this to become a standard: doSomething = () => {} Using a closure could fix this issue. However, benchmarks have them as equal: |
Currently
bind
is being used to preserve context when usingaddEventListener
. The bound function created is then stored in an object$b
per component instance. Would like to improve this.The text was updated successfully, but these errors were encountered: