Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video Alignment on Twitch.tv #109

Closed
Jaden- opened this issue Aug 14, 2020 · 2 comments
Closed

Video Alignment on Twitch.tv #109

Jaden- opened this issue Aug 14, 2020 · 2 comments
Labels
bug Confirmed bug Chrome Issues affecting Chrome Firefox Issues affecting Firefox

Comments

@Jaden-
Copy link

Jaden- commented Aug 14, 2020

Video Alignment (Left, Center, Right) works perfectly on Youtube, but not on Twitch. This is with all other settings set to default. It does somewhat work in combination with other settings, like 21:9 mode + Left, but not on its own.

Youtube, Left aligned. Perfect!
Landscape

Twitch, Left aligned. Black bars on both sides!
image

Tested on both Chrome and Firefox.

Can you please look into this? Video Alignment is my favorite feature about your plugin!

Thank you so much in advance.

@tamius-han tamius-han added bug Confirmed bug Chrome Issues affecting Chrome Firefox Issues affecting Firefox labels Sep 20, 2020
@tamius-han
Copy link
Owner

Note to self: the problem is caused by this:

image

Extension doesn't expect <video> element to get stretched to full width of the player — instead, it's expected that the video will be of the same aspect ratio as the file it's playing.

Because <video> takes up all the space in the player, javascript is like: "hmm, the <video> is 2560px wide? And the player is also 2560px wide? Well, 2560px - 2560px is 0 px of vertical edge, so the video is already aligned! 🎉"

This is also the reason why video alignment on letterboxed content aligns to the wrong end of the monitor (and also cuts off a lil bit extra).

@tamius-han
Copy link
Owner

This bug has been fixed and will be landing on Firefox soon.

Chrome is having a bit of an issue with reviews at the moment though, so this could take weeks on the Chrome side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bug Chrome Issues affecting Chrome Firefox Issues affecting Firefox
Projects
None yet
Development

No branches or pull requests

2 participants