Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[panopto] Videos are clipped when horizontally longer than the display #118

Closed
saschanaz opened this issue Oct 30, 2020 · 3 comments
Closed
Labels
bug Confirmed bug Chrome Issues affecting Chrome Firefox Issues affecting Firefox

Comments

@saschanaz
Copy link

saschanaz commented Oct 30, 2020

Describe the bug

Panopto incorrectly shows 16:9 video way too big on 3:2 display.

(I'm definitely using a 21:9 monitor connected to my Surface Pro but the laptop display is still 3:2.)

To Reproduce

  1. Access https://mozilla.hosted.panopto.com/Panopto/Pages/Viewer.aspx?id=ae2caf59-9253-4ee3-b4cb-ac410123959d
  2. Make the video fullscreen

Expected behavior
What do you think should happen instead?

image

Screenshots

Screenshot

Browser and OS

  • Browser/browser version: Firefox 82/84
  • Operating system: Windows 10
  • Ultrawidify version: 4.4.10

Additional info

The same doesn't happen on YouTube.

@tamius-han tamius-han changed the title Videos are clipped when horizontally longer than the display [panopto] Videos are clipped when horizontally longer than the display Nov 5, 2020
@tamius-han
Copy link
Owner

Think I'm gonna (eventually) close this with 'wontfix,' blacklist the site by default and call it a day because:

  • I really don't like the way things are coded
  • It's not like anyone uses this site
  • And for the handful of users that do, unnecessary black bars prolly don't happen a lot given they seem to mostly host talks and stuff.

Notes to self:

  • Likely broken by width: initial !important bit of CSS that is always enforced (which needs to be there because twitch and IIRC Hulu.
  • Caused by the fact we don't do height: initial !important, because that breaks a few other sites (having both width and height on initial: important may result in videos the size of a postage stamp).
  • Or maybe we could decide which of the two (width, height) we set to initial !important based on player aspect ratio. Prelimiary toying with inspector shows promising results

@tamius-han tamius-han added bug Confirmed bug Chrome Issues affecting Chrome Firefox Issues affecting Firefox labels Nov 5, 2020
@saschanaz
Copy link
Author

Yeah, I just switched to enable it only for allowlisted sites so that it won't affect random sites. It's not that every service has broken videos anyway.

@tamius-han
Copy link
Owner

Turns out this was not just an issue on this site — it was also happening on Netflix and ... on a lot of sites, actually.

Figured why. Things work now, unless you try to do 'fit height' ... in which case, they don't always work quite (at least as far as Netflix is concerned).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bug Chrome Issues affecting Chrome Firefox Issues affecting Firefox
Projects
None yet
Development

No branches or pull requests

2 participants