Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings page broken #16

Closed
tamius-han opened this issue Jan 12, 2018 · 7 comments
Closed

Settings page broken #16

tamius-han opened this issue Jan 12, 2018 · 7 comments
Labels
bug Confirmed bug Chrome Issues affecting Chrome Firefox Issues affecting Firefox Partially fixed The fix was properly implemented, but is not complete yet Waiting for release Issue is fixed, but the fix is not live yet
Milestone

Comments

@tamius-han
Copy link
Owner

Tab switching got broken, presumably while trying to make code more Chrome-friendly?

Don't know. Saving keyboard shortcuts also doesn't work.

@tamius-han tamius-han added bug Confirmed bug Firefox Issues affecting Firefox Chrome Issues affecting Chrome labels Jan 12, 2018
@Mariusmssj
Copy link

Same issue here, the settings can't be saved as buttons don't work and shortcut text can't even be seen unless you highlight it. Previous versions worked far better

@tamius-han
Copy link
Owner Author

Note to self for later when doing blacklist/whitelist editing: don't use SitesConf.js for storing blacklist/whitelist data. These options should be retrieved from Settings.js.

Blacklists & whitelists should be text boxes on 'general extension settings' and 'auto-detection settings' pages, not a site-specific setting.

SitesConf should only store site-specific css hacks and other things.

@System-Glitch
Copy link

Also clicking the autodetection settings does nothing for me on firefox. (I wanted to disable it but I couldn't)

@tamius-han
Copy link
Owner Author

@System-Glitch Well that's a very recent problem (worked a week ago). The fix already up. If auto-update doesn't grab it right away, you can manually download the new version from Mozilla store)

@System-Glitch
Copy link

Firefox tells me I'm using 3.0.0 which is as far as I know the latest version.

@tamius-han
Copy link
Owner Author

Nope, the most recent version on AMO is 3.0.1 as of two-three hours ago.

@System-Glitch
Copy link

I can confirm this is fixed with 3.0.1

@tamius-han tamius-han added this to the 4.0 milestone Nov 18, 2018
@tamius-han tamius-han added Partially fixed The fix was properly implemented, but is not complete yet Waiting for release Issue is fixed, but the fix is not live yet labels Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bug Chrome Issues affecting Chrome Firefox Issues affecting Firefox Partially fixed The fix was properly implemented, but is not complete yet Waiting for release Issue is fixed, but the fix is not live yet
Projects
None yet
Development

No branches or pull requests

3 participants