CI improvements #110
CI improvements #110
Conversation
* change on event to `pull_request` * specify `FORCE_COLOR: 2` * update to `actions/setup-node@v2` * use `npm ci` * add OS-dependent caching * skip the release workflow if the repo isn't `tancredi/fantasticon` * add `fail-fast: false`
|
🎉 This PR is included in version 1.0.32 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@tancredi there's no matrix.os in lint |
|
Also, you could probably remove the cache fallback line |
|
Oopsy - #112 TBH I'd almost remove fallbacks entirely - i'd expect cache keys to be either correct or not, but it kinda just makes the thing more unreadable in a way. What do you think? |
|
I'd say just remove the aforementioned fallback and keep the exact match. Better have a cache miss that cache growing, assuming you it's not a lot slower. |
|
But why that one specifically and not others? |
|
The other one is not a fallback. It's needed so that the cache action knows what to restore AFAICT. |
|
Meh - still not totally convinced as I think caching here is far less critical than maintainability and deffo don't see the point in a fallback key (I'd either hit exact key or not hit anything ay all), for the time being just removed that line :) |
|
Like I said, the only fallback there is is that line wherever repeated. The other line is needed for caching. If you don't want caching, that's another thing, but it definitely speeds things up. |
No description provided.