Skip to content
This repository has been archived by the owner on Oct 7, 2021. It is now read-only.

openh264 for Android arm32 does not use COMMON_ASM_ARM_SRCS #367

Closed
alexcohn opened this issue Mar 30, 2020 · 5 comments
Closed

openh264 for Android arm32 does not use COMMON_ASM_ARM_SRCS #367

alexcohn opened this issue Mar 30, 2020 · 5 comments
Assignees
@tanersener
Labels
enhancement New feature or request fixed

Comments

@alexcohn
Copy link
Contributor

Description
Building openh264 as part of android --full, neon assembly files are excluded. Is this intentional?

Expected behavior
I thought assembly files should be included:

$(COMMON_SRCDIR)/arm/copy_mb_neon.S\
$(COMMON_SRCDIR)/arm/deblocking_neon.S\
$(COMMON_SRCDIR)/arm/expand_picture_neon.S\
$(COMMON_SRCDIR)/arm/intra_pred_common_neon.S\
$(COMMON_SRCDIR)/arm/mc_neon.S\

Current behavior
These files are excluded, by virtue of android-openh264.sh massaging some of original .mk files.

Environment

  • Platform: Android
  • Architecture: arm-v7a-neon
  • Version: 4.3.1
  • Source branch: master
  • Android NDK version: 21.1.6273396
@tanersener tanersener self-assigned this Mar 30, 2020
@tanersener tanersener added the question Further information is requested label Mar 30, 2020
@tanersener
Copy link
Owner

You're right. Those files are not built for arm-v7a-neon. Let me check if it possible to enable them.

@tanersener tanersener added enhancement New feature or request and removed enhancement New feature or request labels Mar 30, 2020
@alexcohn
Copy link
Contributor Author

You're right. Those files are not built for arm-v7a-neon. Let me check if it possible to enable them.

I have a fix for that. Will prepare a pull request by tomorrow.

@tanersener
Copy link
Owner

Thanks. Can you open your pull request against development?

@tanersener tanersener added enhancement New feature or request and removed question Further information is requested labels Mar 30, 2020
@alexcohn alexcohn mentioned this issue Mar 31, 2020
Merged
@tanersener
Copy link
Owner

Fixed in the development branch.

@tanersener
Copy link
Owner

Released with v4.3.2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tanersener tanersener

Labels
enhancement New feature or request fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcohn @tanersener