Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Remove the need for TypedChainIds in the API Endpoints #510

Closed
4 of 5 tasks
shekohex opened this issue May 15, 2023 · 2 comments · Fixed by #519
Closed
4 of 5 tasks

[TASK] Remove the need for TypedChainIds in the API Endpoints #510

shekohex opened this issue May 15, 2023 · 2 comments · Fixed by #519
Assignees
Labels
difficulty: starter 🏁 Small issues that are great for starters or easy to complete tasks

Comments

@shekohex
Copy link
Collaborator

shekohex commented May 15, 2023

Overview

We should be consistent while working and designing our APIs, right now I see a divergence when we query something, for instance when we query the leaves cache or the encrypted outputs, we use the raw chain ids like 5 for Goerli, but when we work with fee info we use the typed chain Ids, which is not human-friendly esp for testing and debugging.

Since now we have two separate Endpoints for Fee informations, we should change the endpoints to use the raw untyped chain ids like the other endpoints we have.

https://github.com/webb-tools/relayer/blob/008b8225a88bcb5ae4a35cb28697fbf4b9c92c02/crates/relayer-handlers/src/lib.rs#L200-L237

Task Checklist

  • Change EVM Fee info to accept the chain_id instead of typed_chain_id
  • Change Substrate Fee info to accept the chain_id instead of typed_chain_id
  • Update tests
  • Update docs (README, docs website, ..etc)
  • Notify the dApp team with these breaking changes before we deploy the new update.
@shekohex shekohex converted this from a draft issue May 15, 2023
@shekohex shekohex added the difficulty: starter 🏁 Small issues that are great for starters or easy to complete tasks label May 15, 2023
@Nutomic
Copy link
Contributor

Nutomic commented May 17, 2023

FYI @drewstone was the one who suggested using TypedChainId for fee endpoints.

#325 (comment)

@shekohex
Copy link
Collaborator Author

FYI @drewstone was the one who suggested using TypedChainId for fee endpoints.

#325 (comment)

This was okay, at least while we only had EVM Fees, but now we have different modules/endpoints for each, no reason to have a typed chain id while the endpoint itself has the part evm or substrate in it.

@shekohex shekohex assigned salman01zp and unassigned Nutomic May 19, 2023
@salman01zp salman01zp moved this from Not Started 🕧 to Building 🏗️ in Webb Universe May 22, 2023
@github-project-automation github-project-automation bot moved this from Building 🏗️ to Completed ✅ in Webb Universe May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: starter 🏁 Small issues that are great for starters or easy to complete tasks
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants