Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Generalize EVM Event Watchers over MerkleSystems instead of VAnchors #564

Closed
4 tasks
shekohex opened this issue Jul 24, 2023 · 0 comments · Fixed by #565
Closed
4 tasks

[TASK] Generalize EVM Event Watchers over MerkleSystems instead of VAnchors #564

shekohex opened this issue Jul 24, 2023 · 0 comments · Fixed by #565
Assignees
Labels
difficulty: starter 🏁 Small issues that are great for starters or easy to complete tasks p1 🟠 Issue should be resolved sooner than later task ✔️

Comments

@shekohex
Copy link
Collaborator

Task Overview

Looks like #500 did not actually fix the root issue with the Syncing leaves and verifying that the new leaves/commitments are valid always works, I discovered that this bug is still there as I was recently testing Webb Alpha dApp with the current Relayers that they use v0.5.0-rc23-alpha which has that bug fix for a while now. But as you may know that some of these nodes just returns the default root since it does not keep the full history, even tho we query the root at specific block number at the time that event of NewCommitment occurred. However some RPCs does only keep the last 250 blocks of state, maybe Infura keeps more than that, but anyway looks like querying the merkle root separately from the event does not work very well.

During the discussion while working on #500, we mentioned emitting the current merkle root along with the commitment itself in one event, this way we can verify and validate the merkle tree without another query to the RPC. During the PR tangle-network/protocol-solidity#328 We noticed a change that Insertion Now Includes newMerkleRoot field which we can utilize to build the merkle tree instead.

Task Checklist

  • Change the handlers to use Insertion Event instead of NewCommitment Event
  • Update tests
  • Pump the relayer version
  • Create a new release.
@shekohex shekohex added feature ➕ Tasks that are functional additions or enhancements difficulty: starter 🏁 Small issues that are great for starters or easy to complete tasks p1 🟠 Issue should be resolved sooner than later task ✔️ and removed feature ➕ Tasks that are functional additions or enhancements labels Jul 24, 2023
@github-project-automation github-project-automation bot moved this to Not Started 🕧 in Webb Universe Jul 24, 2023
@shekohex shekohex self-assigned this Jul 24, 2023
@shekohex shekohex moved this from Not Started 🕧 to Building 🏗️ in Webb Universe Jul 24, 2023
@drewstone drewstone changed the title [TASK] Genrialze EVM Event Watchers over MerkleSystems instead of VAnchors [TASK] Generalize EVM Event Watchers over MerkleSystems instead of VAnchors Jul 24, 2023
@github-project-automation github-project-automation bot moved this from Building 🏗️ to Completed ✅ in Webb Universe Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: starter 🏁 Small issues that are great for starters or easy to complete tasks p1 🟠 Issue should be resolved sooner than later task ✔️
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant