diff --git a/velox/functions/prestosql/tests/DateTimeFunctionsTest.cpp b/velox/functions/prestosql/tests/DateTimeFunctionsTest.cpp index afb8ee459776..c7eb59d26821 100644 --- a/velox/functions/prestosql/tests/DateTimeFunctionsTest.cpp +++ b/velox/functions/prestosql/tests/DateTimeFunctionsTest.cpp @@ -475,32 +475,34 @@ TEST_F(DateTimeFunctionsTest, yearDate) { } TEST_F(DateTimeFunctionsTest, yearTimestampWithTimezone) { + auto yearTimestampWithTimezone = + [&](std::optional timestampWithTimezone) { + return evaluateOnce( + "year(c0)", + TIMESTAMP_WITH_TIME_ZONE(), + TimestampWithTimezone::pack(timestampWithTimezone)); + }; EXPECT_EQ( - 1969, - evaluateWithTimestampWithTimezone("year(c0)", 0, "-01:00")); + 1969, yearTimestampWithTimezone(TimestampWithTimezone(0, "-01:00"))); EXPECT_EQ( - 1970, - evaluateWithTimestampWithTimezone("year(c0)", 0, "+00:00")); + 1970, yearTimestampWithTimezone(TimestampWithTimezone(0, "+00:00"))); EXPECT_EQ( 1973, - evaluateWithTimestampWithTimezone( - "year(c0)", 123456789000, "+14:00")); + yearTimestampWithTimezone(TimestampWithTimezone(123456789000, "+14:00"))); EXPECT_EQ( 1966, - evaluateWithTimestampWithTimezone( - "year(c0)", -123456789000, "+03:00")); + yearTimestampWithTimezone( + TimestampWithTimezone(-123456789000, "+03:00"))); EXPECT_EQ( 2001, - evaluateWithTimestampWithTimezone( - "year(c0)", 987654321000, "-07:00")); + yearTimestampWithTimezone(TimestampWithTimezone(987654321000, "-07:00"))); EXPECT_EQ( 1938, - evaluateWithTimestampWithTimezone( - "year(c0)", -987654321000, "-13:00")); + yearTimestampWithTimezone( + TimestampWithTimezone(-987654321000, "-13:00"))); EXPECT_EQ( std::nullopt, - evaluateWithTimestampWithTimezone( - "year(c0)", std::nullopt, std::nullopt)); + yearTimestampWithTimezone(TimestampWithTimezone::unpack(std::nullopt))); } TEST_F(DateTimeFunctionsTest, weekDate) {