-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new version from external libraires with SRI Support #11
Open
ghost
wants to merge
23
commits into
tanksuzuki:master
Choose a base branch
from
unknown repository
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Font Aesome Default highlight.js
Add padding to nav.level in style.sass to align icons with title on m…
kiliankoe
reviewed
Apr 13, 2017
min_version = 0.16 | ||
|
||
[author] | ||
name = "tanksuzuki" | ||
homepage = "http://tanksuzuki.com" | ||
name = "Malte Kiefer" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not very familiar with the evolution of this theme, but how does removing references to the original author make sense for a PR (with a completely unrelated title as well)?
Follow each `{{ .Site.BaseURL }}` with a single `/`. This is consistent with the interpretation in layouts/partials/header.html and fixes an issue where users cannot host a hugo site from the root directory without specifying the fqdn. Now it is possible to do so by setting the baseurl to the empty string. It would be more elegant to normalise BaseURL usage to expect a string that ends in a slash, but that would break any existing setup where BaseURL does not end in a slash.
Thanks for that work.
Thanks for your work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.