Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Release links from Tanndev-CI are wrong #36

Closed
jftanner opened this issue Oct 29, 2020 · 2 comments
Closed

Release links from Tanndev-CI are wrong #36

jftanner opened this issue Oct 29, 2020 · 2 comments
Assignees
@jftanner
Labels
bug Something isn't working released in beta This feature/request/fix has been published in a beta release released This feature/request/fix has been published in a full release

Comments

@jftanner
Copy link
Member

Bug Report

Tanndev CI links literally https://github.com/tanndev/silence-among-us/issues/github_release_url, because of this setting:

- successComment: "This ${issue.pull_request ? 'pull request is included' : 'issue is resolved'} in version [${nextRelease.version}](<github_release_url>)"

Steps to Reproduce

  1. Release anything linked to an issue.

Expected behavior

It should give a link to the actual release.
@jftanner jftanner added the bug Something isn't working label Oct 29, 2020
@jftanner jftanner self-assigned this Oct 29, 2020
@jftanner jftanner mentioned this issue Oct 29, 2020
Closed
jftanner added a commit that referenced this issue Oct 29, 2020
@jftanner
Fix: Bad links when releasing new versions
ca290a0 
Fixes #36
@Tanndev-CI Tanndev-CI added the released in beta This feature/request/fix has been published in a beta release label Oct 29, 2020
@TannDev TannDev deleted a comment from Tanndev-CI Oct 29, 2020
@jftanner jftanner removed the released in beta This feature/request/fix has been published in a beta release label Oct 29, 2020
@Tanndev-CI
Copy link

This issue is resolved in version 2.6.0-beta.10

@Tanndev-CI Tanndev-CI added the released in beta This feature/request/fix has been published in a beta release label Oct 30, 2020
@Tanndev-CI
Copy link

This issue is resolved in version 2.6.0

@Tanndev-CI Tanndev-CI added the released This feature/request/fix has been published in a full release label Oct 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jftanner jftanner

Labels
bug Something isn't working released in beta This feature/request/fix has been published in a beta release released This feature/request/fix has been published in a full release
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jftanner @Tanndev-CI