Skip to content
This repository has been archived by the owner on Jul 24, 2021. It is now read-only.

Configurable spectator behavior #43

Closed
jftanner opened this issue Nov 2, 2020 · 5 comments
Closed

Configurable spectator behavior #43

jftanner opened this issue Nov 2, 2020 · 5 comments
Labels
enhancement New feature or request released in beta This feature/request/fix has been published in a beta release

Comments

@jftanner
Copy link
Member

jftanner commented Nov 2, 2020

Feature

From #41:

Make [spectator handling] configurable. (I'm thinking mute, ignore dead for settings, with a warning that the last option will impact performance.)

Reasons for Implementing

Some users want spectators to be ignored, other users want them to be muted. whynotboth.gif

Ideas & Details

Add a new spectators config options with three values:

  • mute: Spectators are muted during the game.
  • ignore: Spectators are ignored entirely.
  • dynamic: Spectators are muted/unmuted dynamically along with dead people.
@jftanner jftanner added the enhancement New feature or request label Nov 2, 2020
@jftanner
Copy link
Member Author

jftanner commented Nov 2, 2020

CC @douglasmonsky

@douglasmonsky
Copy link

Adding back the ability to ignore spectators will make my server very happy, appreciate that it is on your to-do list!

jftanner added a commit that referenced this issue Nov 2, 2020
@jftanner
New: Spectator behavior is configurable.
8a1080e 
Use `!sau config set spectators <option>`:
- `mute`: (Default) Keep spectators muted during the game.
- `ignore`: Never mute/unmute spectators.
- `dynamic`: Treat spectators like dead people. (**Not** recommended.)

Fixes #43
@jftanner
Copy link
Member Author

jftanner commented Nov 2, 2020 •
edited
Loading

I think there might be some problems with the spectators: ignore option. Namely, it's possible that the bot will fail to unmute people at the end of the game, if they become spectators automatically.

Unfortunately, I can't test it properly because my personal Discord server is having some pretty severe lag issues. So it's on the beta branch for now, and I'll test it more when I have the chance.

Update: I've managed to test it and I think it's fine. (Unless the player intentionally leaves in the middle of a game.)

@Tanndev-CI
Copy link

This issue is resolved in version 2.7.0-beta.1

@Tanndev-CI Tanndev-CI added the released in beta This feature/request/fix has been published in a beta release label Nov 2, 2020
@jftanner
Copy link
Member Author

Closing this issue because the project will be shuttered soon. See #63.

Hartie95 pushed a commit to Hartie95/silence-among-us that referenced this issue Nov 12, 2022
@jftanner @Hartie95
New: Spectator behavior is configurable.
1b98818 
Use `!sau config set spectators <option>`:
- `mute`: (Default) Keep spectators muted during the game.
- `ignore`: Never mute/unmute spectators.
- `dynamic`: Treat spectators like dead people. (**Not** recommended.)

Fixes TannDev#43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request released in beta This feature/request/fix has been published in a beta release
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jftanner @douglasmonsky @Tanndev-CI