Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (useQuery): apply placeholderData also to disabled queries #2541

Conversation

TkDodo
Copy link
Collaborator

@TkDodo TkDodo commented Aug 5, 2021

by checking for the idle state. this will make idle queries with placeholderData show up as success queries for the observer immediately

closes #1749

by checking for the idle state. this will make idle queries with placeholderData show up as success queries for the observer immediately
@vercel
Copy link

vercel bot commented Aug 5, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tannerlinsley/react-query/8Gi1UMNoqHGbGSUsyZCHhZnf3TXJ
✅ Preview: https://react-query-git-fork-tkdodo-feature-1749-a-0e680a-tannerlinsley.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 5, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9014171:

Sandbox Source
tannerlinsley/react-query: basic Configuration
tannerlinsley/react-query: basic-typescript Configuration
react-query issue Issue #1749

@TkDodo TkDodo merged commit 418c48f into TanStack:master Aug 10, 2021
@TkDodo TkDodo deleted the feature/1749-apply-placeholder-data-to-disabled-queries branch August 10, 2021 09:00
@tannerlinsley
Copy link
Collaborator

🎉 This PR is included in version 3.19.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

placeholderData not applied when query is disabled
2 participants