fix(core): change shouldFetchOptionally condition
#2556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/tannerlinsley/react-query/9aHMnSCooAbKNSo9bLf5zZ1EP9zM |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9b0e0e4:
|
TkDodo
reviewed
Aug 10, 2021
Change this condition to not change the status of result to 'loading' when state.status is 'error' Fixes TanStack#2187
JaeYeopHan
force-pushed
the
fix/shouldFetchOptionally-condition
branch
from
b5686c2 to
464b605
Compare
Change to refer to the previous query value.
Check prevQuery.state.status only when prevOptions.enabled is false
TkDodo
approved these changes
Aug 11, 2021
|
🎉 This PR is included in version 3.19.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
2 tasks
TkDodo
added a commit
to TkDodo/react-query
that referenced
this pull request
Sep 18, 2021
the change in shouldFetchOptionally was introduced in TanStack#2556 to avoid an infinite loop wen using suspense (see TanStack#2187), but it broke the case where we're switching keys between two erroneous queries - they now didn't refetch even though they should this fix scopes the error check to only usages where suspense is turned on, so that we get the same behaviour as in v3.19.4 for non-suspense users, while still having the fix for suspense users
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #2187
Description
Change
shouldFetchOptionallycondition to not change thestatusof result toloadingwhenstate.statusiserror.result.isLoadingistruein this line whenresult.error != nullcreateResultfunction andshouldFetchOptionallyfunctionFixes #2187