Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable externalHelpers for async-to-promise transform #490

Merged
merged 1 commit into from
May 14, 2020

Conversation

henryqdineen
Copy link
Contributor

This is something I noticed while evaluation react-query for use at my company. Several of the helpers from babel-plugin-transform-async-to-promises (await(), async(), invoke(), catch(), and empty()) are duplicated in the source code. Enabling the currently undocumented externalHelpers option will fix this duplication and save a few bytes. Thanks!

@henryqdineen henryqdineen force-pushed the externalHelpers branch 2 times, most recently from 80f937e to 5f969f2 Compare May 14, 2020 03:40
@tannerlinsley tannerlinsley merged commit 99fd145 into TanStack:master May 14, 2020
@tannerlinsley
Copy link
Collaborator

🎉 This PR is included in version 1.4.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants