Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgraded connection pool blocks program from exiting #213

Closed
tetigi opened this issue Oct 10, 2018 · 2 comments
Closed

Upgraded connection pool blocks program from exiting #213

tetigi opened this issue Oct 10, 2018 · 2 comments
Labels
bug

Comments

@tetigi
Copy link

tetigi commented Oct 10, 2018 •
edited
Loading

Hey there -

We're using Carmine 2.19.0, and it seems that the connection pools are blocking the Java process from exiting. I have created a minimal project demonstrating the problem here, along with a description of the behaviour: https://github.com/tetigi/carmine-issue

Have confirmed that the blocking happens on two different devices, on Java 8, 9 and 10. Downgrading Carmine to 2.18.2 or not creating a thread pool (:pool :none) fixes the problem.

Still trying to figure out what the exact problem with commons-pool2 is. Seems like it was introduced in this commit: b850ebb
@ptaoussanis
Copy link
Member

Hi there, thanks for the report. Confirmed on my end.

Looks like an upstream bug from commons-pool. Since we don't actually need the newest version, will issue a hotfix shortly that reverts the version bump update.

ptaoussanis added a commit that referenced this issue Oct 14, 2018
@ptaoussanis
[#213] Hotfix: revert commons-pool dep update
13a65d0 
Seems that there's an issue with newer commons-pool releases
(incl. 2.5.0 and 2.6.0 from what I can tell) that prevents JVM
shutdown - for example during `lein uberjar`.

A quick look at the commons-pool issues turned this up:
  https://issues.apache.org/jira/browse/POOL-348

Since there's no particular need for Carmine to use the newer
versions, will revert the update in the meantime.
@tetigi
Copy link
Author

tetigi commented Oct 15, 2018

Thanks for the quick fix! Looks great now.

@tetigi tetigi closed this as completed Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ptaoussanis @tetigi