Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Default date time stamp use ISO8601 #155

Closed
aboy021 opened this issue Feb 25, 2016 · 6 comments
Closed

Feature request: Default date time stamp use ISO8601 #155

aboy021 opened this issue Feb 25, 2016 · 6 comments

Comments

@aboy021
Copy link

aboy021 commented Feb 25, 2016

ISO 8601 is the only sane date format (obligatory xkcd link).
It would be great if default-output-fn used this format, or at least had an option to enable it.

@ptaoussanis
Copy link
Member

Hi there,

It would be great if default-output-fn used this format, or at least had an option to enable it.

You can use :iso8601 as the format. Please see #135 if you'd like details on why this isn't the default.

@aboy021
Copy link
Author

aboy021 commented Feb 25, 2016

Thanks for getting back to me so quickly.

I'd love to be able to use :iso8601, but it looks like the change mentioned in #135 hasn't made it into the current master. None of the lovely patterns you created are in the current timbre.cljx and the only mention of iso8601 is in a comment.

It's a great feature, and if it does get merged into master, it would be great to add some mention of it to the README.md.

@ptaoussanis
Copy link
Member

Thanks for getting back to me so quickly.

No problem

I'd love to be able to use :iso8601, but it looks like the change mentioned in #135 hasn't made it into the current master.

Looks like #135 has been in master since v4.2.0 (Dec 27 2015). There's no docs on it, but it should work - is it not for you?

Note that the actual code change was in https://github.com/ptaoussanis/encore, not timbre.cljx.

It's a great feature, and if it does get merged into master, it would be great to add some mention of it to the README.md.

Sure, PR welcome :-)

@aboy021 aboy021 closed this as completed Feb 25, 2016
@cjohansen
Copy link

Just spent some time trying to get timbre to print timestamps the same way basically all my other tools does it, and came by this. I would enthusiastically vote for 8601 as the default, it just takes too much mental effort to work with slightly deviating patterns like the one timbre currently uses. I'll take the :pattern :iso8601 for now, but I'd suggest a prominent mention of that feature in the readme.

@ptaoussanis
Copy link
Member

Will update the default pattern with the next release 👍

@cjohansen
Copy link

Awesome, thanks!

ptaoussanis pushed a commit to taoensso/encore that referenced this issue Dec 2, 2018
The ISO8601 separator is wrong. It should print timestamps like "2018-11-24T16:00:48.999Z" instead of "2018-11-24 16:00:48.999+0000" (for UTC).

Related to taoensso/timbre#155
ptaoussanis pushed a commit to taoensso/encore that referenced this issue Dec 2, 2018
The ISO8601 separator is wrong. It should print timestamps like "2018-11-24T16:00:48.999Z" instead of "2018-11-24 16:00:48.999+0000" (for UTC).

Related to taoensso/timbre#155
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants