-
-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No error for unending test when running in browser #201
Comments
Which test doesn't end? |
@whasting timeouts. |
We could add a default 30s timeout to each block |
How does tape determine that it's done when running in the browser? I have a never ending test and tape claims it's done:
|
Timeouts don't appear to work in the browser:
produces this output:
|
I'm having the same problem with Webpack-bundled tests. If a test fails, tape never gets the error. It just sits forever. I'm beginning to think it's actually a Webpack problem, not a tape problem. I know it's been a while, but did anyone ever get anywhere with this? |
Unending tests are verified in process's |
Seems like something we could watch for on the |
That would require the user to manually guess that the tests should be done and close the window, then you can pop up an "Are you sure you want to close this window?" prompt. I have completely abandoned Tape in browsers for this reason. It's been months since I tried it, but I had something that launched the browser and ran the tests automatically. It would wait for Tape to give the signal that it's done before closing the window. |
@AsaAyers how would you propose a browser know when unending tests should be considered done? |
I don't believe there is any functional replacement for You may need to look into how other test runners manage this. I have only looked deep enough into the code to find the |
I'm having the same problem under jspm @geekytime . Any workaround here? |
I'm using Tape to test a practice Promise implementation.
When I run my tests in the browser, I notice that Tape does not throw an exception for an unending test like it does when run through Node. Note that I'm using Webpack to bundle Tape, my tests, and my implementation code.
It looks like Tape relies on
process.on('exit')
to detect unending tests. Since this isn't available in the browser, does anyone know what I can to do get an exception thrown when a test doesn't end?The text was updated successfully, but these errors were encountered: