Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove archive.commit() depreciated method? #20

Open
halas opened this issue Nov 6, 2018 · 1 comment
Open

Remove archive.commit() depreciated method? #20

halas opened this issue Nov 6, 2018 · 1 comment

Comments

@halas
Copy link

halas commented Nov 6, 2018

There is a console warning:
The DatArchive commit() API has been deprecated. as indeed it is listed as depreciated method here dat://beakerbrowser.com/docs/apis/dat#commit
Although it is not clear to me what this method did. When I removed this line:

paste-dat/index.js

Line 43 in 49ca096

await archive.commit()

All seemed to work fine.
@halas
Copy link
Author

halas commented Nov 7, 2018

On irc @pfrazeee clarified this can be probably safely removed.
I made a PR: #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@halas