R packet tracker fix #2672
Closed
R packet tracker fix #2672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
andrewfullard
previously approved these changes
Jun 21, 2024
|
*beep* *bop* Hi, human. The Click here to see your results. |
| interaction_type = ( | ||
| simulation_rpacket_tracking_enabled.transport.transport_state.last_interaction_type | ||
| ) | ||
| mask = interaction_type == 2 |
| @@ -264,8 +264,9 @@ def single_packet_loop( | |||
| ) | |||
| else: | |||
| pass | |||
| if montecarlo_configuration.ENABLE_RPACKET_TRACKING: | |||
| rpacket_tracker.track(r_packet) | |||
| if interaction_type != InteractionType.BOUNDARY: | |||
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2672 +/- ##
==========================================
+ Coverage 67.89% 69.36% +1.46%
==========================================
Files 174 179 +5
Lines 14439 14315 -124
==========================================
+ Hits 9804 9930 +126
+ Misses 4635 4385 -250 ☔ View full report in Codecov by Sentry. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Type: 🪲
bugfixFixes #2671
This PR fixes the way RPacketTracker tracks the packet. Also, since no tests were written for rpacket_tracker. I wrote some of them.
🚦 Testing
How did you test these changes?
pytest -vvs tardis/transport/montecarlo/tests/test_rpacket_tracker.py --tardis-refdata=/home/sam/TARDIS/tardis-refdata☑️ Checklist
build_docslabel