Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark fix for github actions #2702

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

officialasishkumar
Copy link
Member

@officialasishkumar officialasishkumar commented Jul 12, 2024

📝 Description

Type: 🪲 bugfix

Fixes the current action

📌 Resources

Note: Just for surety before merging we should wait for the action to finish.

This is how i checked it prior to the creation of this PR:

I ran it in chunks just to save some time. For the first time, run_tardis failed for some reasons in actions but others passed https://github.com/officialasishkumar/tardis/actions/runs/9910265728/job/27380239908

and the second time after fix, i only ran run_tardis whose actions can be found at https://github.com/officialasishkumar/tardis/actions/runs/9783164239/job/27011119081 which passed

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.38%. Comparing base (17b1da4) to head (2cc765a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2702   +/-   ##
=======================================
  Coverage   38.38%   38.38%           
=======================================
  Files         181      181           
  Lines       14471    14471           
=======================================
  Hits         5554     5554           
  Misses       8917     8917           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewfullard
Copy link
Contributor

Good work, appears to be functioning on your fork. The benchmarks taking more than an hour is probably a bad sign though!

@atharva-2001
Copy link
Member

Looks fine to me too.

@andrewfullard andrewfullard merged commit a947ad4 into tardis-sn:master Jul 15, 2024
14 of 19 checks passed
sarthak-dv pushed a commit to sarthak-dv/tardis that referenced this pull request Jul 16, 2024
fix benchmark

Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
sarthak-dv pushed a commit to sarthak-dv/tardis that referenced this pull request Jul 16, 2024
fix benchmark

Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants