Merge pull request #13 from tarfin-labs/documentation-fix

documentation and error code description changes
tarfin-labs · Mar 5, 2020 · 92a1a5e · 92a1a5e
2 parents 7860bfe + 1f25715
commit 92a1a5e
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,11 @@ All notable changes to `netgsm` will be documented in this file
 
 ## Unreleased
 
+## 2.1.1 - 2020-03-05
+
+- "vendor:publish" section in the documentation has been fixed.
+- error code descriptions fixed for balance service
+
 ## 2.1.0 - 2020-03-04
 
 - added an exception for unhandled netgsm error codes.

diff --git a/README.md b/README.md
@@ -39,7 +39,7 @@ composer require tarfin-labs/netgsm
 Next, you should publish the Laravel config migration file using the vendor:publish Artisan command.
 
 ```
-php artisan vendor:publish --provider="TarfinLabs\Netgsm\NetgsmServiceProvider" --tag="netgsm"
+php artisan vendor:publish --provider="TarfinLabs\Netgsm\NetgsmServiceProvider" --tag="config"
 ```
 
 ### Setting up the Netgsm service

diff --git a/src/Balance/NetgsmAvailableCredit.php b/src/Balance/NetgsmAvailableCredit.php
@@ -31,7 +31,7 @@ class NetgsmAvailableCredit extends NetgsmApiClient
      */
     protected $errorCodes = [
         '30'  => NetgsmErrors::CREDENTIALS_INCORRECT,
-        '40'  => NetgsmErrors::CREDENTIALS_INCORRECT,
+        '40'  => NetgsmErrors::NO_RECORD,
         '100' => NetgsmErrors::SYSTEM_ERROR,
     ];
 

diff --git a/src/Balance/NetgsmPackages.php b/src/Balance/NetgsmPackages.php
@@ -23,8 +23,8 @@ class NetgsmPackages extends NetgsmApiClient
      * @var array
      */
     protected $errorCodes = [
-        '30'  => NetgsmErrors::MESSAGE_TOO_LONG,
-        '40'  => NetgsmErrors::CREDENTIALS_INCORRECT,
+        '30'  => NetgsmErrors::CREDENTIALS_INCORRECT,
+        '40'  => NetgsmErrors::NO_RECORD,
         '100' => NetgsmErrors::SYSTEM_ERROR,
     ];