dev: replace webpack-dev-server with watch #2246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dctalbot
suggested changes
Mar 16, 2022
Co-authored-by: David Talbot <17692467+dctalbot@users.noreply.github.com>
dctalbot
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR replaces the use of
webpack-dev-serverand the required proxy with a method that will serve files from the local filesystem or in memory. For localdev, webpack is run in watch mode and a new tool live.js polls for changes to UI files.This is in prep for the esbuild work on the graphql explorer.
Review Tips
Everything should work as it did before, though
make startmay start a little faster. If you already have code inweb/src/buildit will be served while the dev build runs in the background instead of getting a hang with "wait until bundle complete" warning.Changes to
index.htmlorapp.jsshould result in a page reload as they always have.