calendar subscription: increase calculated shifts from 1 month to 1 year #2388
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make check
to catch common errors. Fixed any that came up.Description:
This PR increases the calendar subscription window of calculated shifts from 1 month to 1 year.
Which issue(s) this PR fixes:
Fixes #1459
Describe any introduced user-facing changes:
This change will not require any action from any users that have existing subscriptions created. The next time a calendar agent fetches from subscription endpoint, data for the full year will be pulled.
Notes:
An analysis of impact using a worst case scenario for number of shifts (hourly rotation with 2 users, on call 24x7) resulted in a payload of 1.2 MB for 1 year (from 102 KB for 1 month). No noticeable detrimental effect on query execution times or request duration on calendar subscription endpoint. Application logs were reviewed and real-world payload sizes were substantially smaller than test case above, so the increase in window duration should not be impactful.