Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calendar subscription: increase calculated shifts from 1 month to 1 year #2388

Merged
merged 1 commit into from
May 11, 2022

Conversation

m17ch
Copy link
Contributor

@m17ch m17ch commented May 11, 2022

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
This PR increases the calendar subscription window of calculated shifts from 1 month to 1 year.

Which issue(s) this PR fixes:
Fixes #1459

Describe any introduced user-facing changes:
This change will not require any action from any users that have existing subscriptions created. The next time a calendar agent fetches from subscription endpoint, data for the full year will be pulled.

Notes:
An analysis of impact using a worst case scenario for number of shifts (hourly rotation with 2 users, on call 24x7) resulted in a payload of 1.2 MB for 1 year (from 102 KB for 1 month). No noticeable detrimental effect on query execution times or request duration on calendar subscription endpoint. Application logs were reviewed and real-world payload sizes were substantially smaller than test case above, so the increase in window duration should not be impactful.

Copy link
Contributor

@Forfold Forfold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, and thanks for taking the time to thoroughly review any potential impacts!

@mastercactapus mastercactapus merged commit b51e030 into master May 11, 2022
@mastercactapus mastercactapus deleted the cal-sub-duration branch May 11, 2022 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase duration of calendar subscription
3 participants