From b44f5fd678900c6399a8cc0e1045f1a144e9151b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Fri, 17 Mar 2017 11:17:49 +0100 Subject: [PATCH] deps: cherry-pick c5c570f from upstream V8 Original commit message: [build] Fix gyp files for building inspector This patch fixes compilation of V8 with inspector on Windows as well as cross-compilation of the V8 inspector. BUG= Refs: https://github.com/nodejs/node/pull/10992 Review-Url: https://codereview.chromium.org/2705423003 Cr-Commit-Position: refs/heads/master@{#43533} --- deps/v8/gypfiles/toolchain.gypi | 2 -- deps/v8/src/inspector/inspector.gyp | 28 ++++++++++++++++++++++++++++ 2 files changed, 28 insertions(+), 2 deletions(-) diff --git a/deps/v8/gypfiles/toolchain.gypi b/deps/v8/gypfiles/toolchain.gypi index 9c8f4a29012e32..88afb8612e4be9 100644 --- a/deps/v8/gypfiles/toolchain.gypi +++ b/deps/v8/gypfiles/toolchain.gypi @@ -991,8 +991,6 @@ # present in VS 2003 and earlier. 'msvs_disabled_warnings': [4351], 'msvs_configuration_attributes': { - 'OutputDirectory': '<(DEPTH)\\build\\$(ConfigurationName)', - 'IntermediateDirectory': '$(OutDir)\\obj\\$(ProjectName)', 'CharacterSet': '1', }, }], diff --git a/deps/v8/src/inspector/inspector.gyp b/deps/v8/src/inspector/inspector.gyp index c70722f852b608..91507bd579f798 100644 --- a/deps/v8/src/inspector/inspector.gyp +++ b/deps/v8/src/inspector/inspector.gyp @@ -13,6 +13,13 @@ 'targets': [ { 'target_name': 'inspector_injected_script', 'type': 'none', + 'conditions': [ + ['want_separate_host_toolset==1', { + 'toolsets': ['host', 'target'], + }, { + 'toolsets': ['target'], + }] + ], 'actions': [ { 'action_name': 'convert_js_to_cpp_char_array', @@ -37,6 +44,13 @@ }, { 'target_name': 'inspector_debugger_script', 'type': 'none', + 'conditions': [ + ['want_separate_host_toolset==1', { + 'toolsets': ['host', 'target'], + }, { + 'toolsets': ['target'], + }] + ], 'actions': [ { 'action_name': 'convert_js_to_cpp_char_array', @@ -61,6 +75,13 @@ }, { 'target_name': 'protocol_compatibility', 'type': 'none', + 'conditions': [ + ['want_separate_host_toolset==1', { + 'toolsets': ['host', 'target'], + }, { + 'toolsets': ['target'], + }] + ], 'actions': [ { 'action_name': 'protocol_compatibility', @@ -83,6 +104,13 @@ { 'target_name': 'protocol_generated_sources', 'type': 'none', 'dependencies': [ 'protocol_compatibility' ], + 'conditions': [ + ['want_separate_host_toolset==1', { + 'toolsets': ['host', 'target'], + }, { + 'toolsets': ['target'], + }] + ], 'actions': [ { 'action_name': 'protocol_generated_sources',