Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate flaky test - esm_display_syntax_error_import_json_named_export #6

Closed
targos opened this issue Nov 6, 2021 · 0 comments
Closed
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI.

Comments

@targos
Copy link
Owner

targos commented Nov 6, 2021

Test

message/esm_display_syntax_error_import_json_named_export

Platform

linuxone

Console output

(node:11257) ExperimentalWarning: Importing JSON modules is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
file:///data/iojs/build/workspace/node-test-commit-linuxone/test/message/esm_display_syntax_error_import_json_named_export.mjs:4
import { ofLife } from '../fixtures/experimental.json' assert { type: 'json' };
         ^^^^^^
SyntaxError: The requested module '../fixtures/experimental.json' does not provide an export named 'ofLife'
    at ModuleJob._instantiate (node:internal/modules/esm/module_job:127:21)
    at async ModuleJob.run (node:internal/modules/esm/module_job:191:5)
    at async Promise.all (index 0)
    at async ESMLoader.import (node:internal/modules/esm/loader:331:24)
    at async loadESM (node:internal/process/esm_loader:88:5)
    at async handleMainPromise (node:internal/modules/run_main:65:12)

Node.js v18.0.0-pre

Build links

Additional information

The test seems to fail because of the first two lines that come from the experimental warning.
These lines are not in the .out file, which seems like a mistake, but I don't understand why the test is not failing consistently on all platforms.

@targos targos added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Nov 6, 2021
@targos targos closed this as completed Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI.
Projects
None yet
Development

No branches or pull requests

1 participant