fix: oms validation #6161
Merged
fix: oms validation #6161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (CI)1 260 tests 1 260 ✅ 12m 59s ⏱️ Results for commit 88e9c9b. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
added
P-acks_required
hansieodendaal
previously approved these changes
Feb 21, 2024
base_layer/wallet/src/output_manager_service/tasks/txo_validation_task.rs
Show resolved
Hide resolved
ghpbot-tari-project
removed
P-reviews_required
ghpbot-tari-project
added
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the OMS validation to invalidate unmined utxos and not keep them pending
Motivation and Context
Although these utxo would never reach spending, the wallet sees them as pending incoming or pending outgoing. We need to ensure their status is correctly set.