feat: make the make_it_rain submission rate a float #6180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This PR will allow a wider transaction submission rate for the make-it-rain tests. - Also fixed cucmber tests where it needed to detect transactions with a certain status. This was needed to fix the make-it-rain cucumber test.
Test Results (CI) 3 files 117 suites 36m 53s ⏱️ Results for commit 10fe583. |
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests) 2 files + 2 11 suites +11 20m 54s ⏱️ + 20m 54s For more details on these failures, see this check. Results for commit 10fe583. ± Comparison against base commit aaad66e. |
SWvheerden
approved these changes
Mar 5, 2024
ghpbot-tari-project
removed
the
P-reviews_required
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Mar 5, 2024
* development: feat: make the make_it_rain submission rate a float (tari-project#6180) feat: wallet ffi use dns (tari-project#6152) chore: add localnet gen block (tari-project#6176) fix: hide unmined coinbase (tari-project#6159) chore: removes panics from wallet burn task (tari-project#6163) test: fix cucumber network environment (tari-project#6175) feat: lazily evaluate for new random_x template (tari-project#6170)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
A transaction submission fractional rate of between 1 and 2 txns/s is required for extended stress tests.
How Has This Been Tested?
Cucumber test
Scenario: As a user I want to make-it-rain via command lineWhat process can a PR reviewer use to test or verify this change?
Cucumber test
Scenario: As a user I want to make-it-rain via command lineBreaking Changes