Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: limit script max size #6364

Merged
merged 1 commit into from
May 31, 2024
Merged

feat: limit script max size #6364

merged 1 commit into from
May 31, 2024

Conversation

SWvheerden
Copy link
Collaborator

Description

Current script max size is 2kb, this reduces it down to 512 bytes.

@SWvheerden SWvheerden requested a review from a team as a code owner May 31, 2024 09:47
@ghpbot-tari-project ghpbot-tari-project added the CR-insufficient_context Your PRs commit messages don't provide enough context to justify accepting the change. label May 31, 2024
@github-actions GitHub Actions
Copy link

Test Results (CI)

    3 files    120 suites   41m 21s ⏱️
1 294 tests 1 294 ✅ 0 💤 0 ❌
3 874 runs  3 874 ✅ 0 💤 0 ❌

Results for commit 3c45da7.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels May 31, 2024
@github-actions GitHub Actions
Copy link

Test Results (Integration tests)

 2 files  + 2  11 suites  +11   13m 37s ⏱️ + 13m 37s
34 tests +34  32 ✅ +32  0 💤 ±0  2 ❌ +2 
37 runs  +37  33 ✅ +33  0 💤 ±0  4 ❌ +4 

For more details on these failures, see this check.

Results for commit 3c45da7. ± Comparison against base commit 4c0ce46.

hansieodendaal
hansieodendaal approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label May 31, 2024
@SWvheerden SWvheerden merged commit 0fd2efe into tari-project:development May 31, 2024
14 of 16 checks passed
@SWvheerden SWvheerden deleted the reduce_taru_scrpt_size branch June 3, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hansieodendaal hansieodendaal hansieodendaal approved these changes

Assignees
No one assigned
Labels
CR-insufficient_context Your PRs commit messages don't provide enough context to justify accepting the change. P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SWvheerden @hansieodendaal @ghpbot-tari-project