Fix DecentralandUtils.getAllAssetsForSale

[marcelomorgado]

Issue link

#299

Auto-close the issue?

Closes #299

Types of changes

Bug fix (non-breaking change that fixes an issue)

Notes

• DecentrandUtils.getAllAssetsForSale was returning overwrote and canceled sell orders.
• With this fix we can back to show parcels on the app.

[pcowgill]

@marcelomorgado Nicely done! I'll merge this once the tests finish running

[pcowgill]

@marcelomorgado This test failed:

1) TasitAction.Contract
tasit-action:        Transactions (Actions) Subscription
tasit-action:          should emit error event when block reorganization occurs - tx confirmed twice:
tasit-action:       AssertionError: expected false to be true
tasit-action:       + expected - actual
tasit-action:       -false
tasit-action:       +true
tasit-action:       
tasit-action:       at Context.it (src/contract/Contract.test.js:500:7)

[marcelomorgado]

@marcelomorgado This test failed:

1) TasitAction.Contract
tasit-action:        Transactions (Actions) Subscription
tasit-action:          should emit error event when block reorganization occurs - tx confirmed twice:
tasit-action:       AssertionError: expected false to be true
tasit-action:       + expected - actual
tasit-action:       -false
tasit-action:       +true
tasit-action:       
tasit-action:       at Context.it (src/contract/Contract.test.js:500:7)

Looking into that now

[marcelomorgado]

I've rerun the test and it passes. Seems another non-deterministic test case.

[pcowgill]

I've rerun the test and it passes. Seems another non-deterministic test case.

Ah ok, darn. Maybe flag that with an issue if there isn't one already?

[marcelomorgado]

I've rerun the test and it passes. Seems another non-deterministic test case.

Ah ok, darn. Maybe flag that with an issue if there isn't one already?

#329