Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out what contract-based account address would be using CREATE2 #362

Open
pcowgill opened this issue May 1, 2019 · 2 comments
Open
Labels
enhancement New feature or request

Comments

@pcowgill
Copy link
Member

pcowgill commented May 1, 2019

No description provided.

@pcowgill pcowgill added the enhancement New feature or request label May 1, 2019
@marcelomorgado
Copy link
Contributor

Did you mean CREATE instead of CREATE2? We are using a pre-deployed contract from tasit-contracts to tests. We should move to add the deployment process to the tasit-contract-based-account test suite and use that.

@pcowgill
Copy link
Member Author

pcowgill commented May 2, 2019

Hmm, I mean CREATE2.

This would be for a user of an app powered by the SDK. The use case I'm picturing here is mostly for if we wanted to deploy a contract-based-account for the user. Or rather, if we wanted to know the address of the contract before having the eth to deploy it, but still sending something to it ahead of time. So counterfactual deployment, to use the technical term.

When talking about pre-deployed contracts, do you mean singleton contracts like the Decentraland Marketplace or the Gnosis Safe one?

For our tests, we'd still use our pre-deployed contracts of other 3rd party deps for all singleton contracts. I agree that deploying a separate Safe contract for each test run could be interesting to explore in the future (although that's a separate topic). And having that deployment happen as part of tasit-contract-based-account could make sense. I'll have to ponder that more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants