You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Did you mean CREATE instead of CREATE2? We are using a pre-deployed contract from tasit-contracts to tests. We should move to add the deployment process to the tasit-contract-based-account test suite and use that.
This would be for a user of an app powered by the SDK. The use case I'm picturing here is mostly for if we wanted to deploy a contract-based-account for the user. Or rather, if we wanted to know the address of the contract before having the eth to deploy it, but still sending something to it ahead of time. So counterfactual deployment, to use the technical term.
When talking about pre-deployed contracts, do you mean singleton contracts like the Decentraland Marketplace or the Gnosis Safe one?
For our tests, we'd still use our pre-deployed contracts of other 3rd party deps for all singleton contracts. I agree that deploying a separate Safe contract for each test run could be interesting to explore in the future (although that's a separate topic). And having that deployment happen as part of tasit-contract-based-account could make sense. I'll have to ponder that more.
No description provided.
The text was updated successfully, but these errors were encountered: