Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinger.run() should return immediately when packet recieved #18

Open
woodsaj opened this issue Nov 30, 2015 · 4 comments
Open

Pinger.run() should return immediately when packet recieved #18

woodsaj opened this issue Nov 30, 2015 · 4 comments

Comments

@woodsaj
Copy link

woodsaj commented Nov 30, 2015

Regardless of the latency of the ICMP packets, Pinger.Run() currently only returns after MaxRTT.

I understanding using MaxRTT to space pings when running with RunLoop(), but when i explicitly call Pinger.Run(), I want it to return as soon as the response ICMP packet is received.

@woodsaj
Copy link
Author

woodsaj commented Nov 30, 2015

This change also ensures that OnIdle() is only called when MaxRTT is reached and no packet has been received.

@traveller42
Copy link

This could have detrimental effects if one is pinging multiple targets.

@kanocz
Copy link
Contributor

kanocz commented Sep 18, 2016

It's possible, but only with bigger changes that breaks compatibility with original version, like I have in https://github.com/kanocz/go-fastping :-(

@harshitha-bt
Copy link

So this is not yet fixed in this repo right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants