Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddIP/RemoveIP() AddIPAddr/RemoveIPAddr() could make a panic in concurrent environment #31

Open
snaix opened this issue May 11, 2017 · 0 comments

Comments

@snaix
Copy link

snaix commented May 11, 2017

Hi
I found that fastping could panic when call RemoveIP() in other goroutine:
fastping fatal error: concurrent map iteration and map write
The panic point in sendICMP():

	...
	for key, addr := range p.addrs {
	...

Which an unprotected p.addrs in concurrent enviroment.
So when I was running p.RunLoop() without p.Stop(), and call p.RemoveIP() in another goroutine.
A panic will happen:
fastping fatal error: concurrent map iteration and map write

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant