New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed max_length=1024 in model.generate() #3

Open

Mooler0410 opened this issue Dec 2, 2023 · 1 comment

Mooler0410 commented Dec 2, 2023

In the scripts for hf, I found the max_token of .generate() is set as a fixed number: 1024

= model.generate(model_input,
max_length=1024,
do_sample=False,

But this does not make sense for much larger max_input_length.

Should the max_new_token argument be set as 1024 rather than max_length?

Collaborator

UriSha commented Feb 8, 2024

Hi @Mooler0410.

You are right, I changed it to use max_new_tokens.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment