Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[updater] Updating macOS app from Tauri v1 to v2 fails to restart #1746

Closed
calejvaldez opened this issue Sep 7, 2024 · 13 comments
Closed

[updater] Updating macOS app from Tauri v1 to v2 fails to restart #1746

calejvaldez opened this issue Sep 7, 2024 · 13 comments
Assignees
Labels
bug Something isn't working platform: macos macOS specific issues plugin: updater status: upstream This issue needs to be fixed in an upstream project

Comments

@calejvaldez
Copy link
Contributor

I have a Tauri app, and when I attempt to update a v1 app to a v2 version, the program gets stuck when I select "Yes" after being asked to restart.

The v1 version ends up being replaced in the /Applications folder, but it just doesn't restart to the v2 version.

@FabianLars
Copy link
Member

FabianLars commented Sep 9, 2024

Can you check whether it's the same as #1724? So, do the file names differ?

edit: also linking tauri-apps/tauri#10355 just so we don't forget to close anything once resolved.

@FabianLars FabianLars added bug Something isn't working platform: macos macOS specific issues plugin: updater labels Sep 9, 2024
@calejvaldez
Copy link
Contributor Author

The files names don't differ. They both end up being You Are Typing.app. I check the Applications folder and only one version exists. When I manually reset it, I check the About menu option and I see that the old version was properly replaced.

These seem to be two different problems.

@FabianLars
Copy link
Member

Okay, thanks. Since this is the v1 updater failing and not this plugin i'll mark this as an upstream issue. On that note, is the project in question public so we can check it out?

@FabianLars
Copy link
Member

/upstream tauri-apps/tauri

@tauri-apps tauri-apps bot added the status: upstream This issue needs to be fixed in an upstream project label Sep 9, 2024
@calejvaldez
Copy link
Contributor Author

Yeah, it's You Are Typing.

I should mention that 1.3.3 and 1.3.4 are the ones with Tauri v2. I eventually went back to v1.

Sorry for all the issues, but thank you for working on it!! 🫡

@FabianLars
Copy link
Member

so i assume updates from v1 to v1 work fine meaning it's not a permission issue (which would be a known issue on macos) 🤔

@calejvaldez
Copy link
Contributor Author

calejvaldez commented Sep 9, 2024

Yup! v1->v1 work perfectly fine. :)

Edit: v1 -> v2 is where issues arise. and v2 -> v2 doesn't display the update dialog, as mentioned in #1747.

Edit 2: Found out the Updater plugin requires us to manually check for updates. My bad!

@tweidinger
Copy link
Contributor

Is the issue solved on your end then @calejvaldez?

@calejvaldez
Copy link
Contributor Author

@tweidinger Issue is resolved for #1747, not for this issue. The v2 -> v2 problem was unrelated to this one, I just thought I should mention it. :)

@lucasfernog lucasfernog self-assigned this Sep 13, 2024
@lucasfernog
Copy link
Member

lucasfernog commented Sep 13, 2024

hmm I've recently written a e2e test for the v1->v2 updater, it's working but i'll test with your repo to see what's missing.
EDIT: oh it's actually the restart step.. interesting, i'll get to it tomorrow

@calejvaldez
Copy link
Contributor Author

@lucasfernog That might be a bit tricky because I reverted the project to v1 in 1.3.5.

The v2 projects are 1.3.3 and 1.3.4... though I don't know how we'd test the updater if the latest version is 1.3.6 which is built with v1. :c

@lucasfernog
Copy link
Member

no worries we'll figure it out

@calejvaldez
Copy link
Contributor Author

Closing as a fix was merged! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working platform: macos macOS specific issues plugin: updater status: upstream This issue needs to be fixed in an upstream project
Projects
None yet
Development

No branches or pull requests

4 participants