Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[authenticator] tauri-plugin-authenticator depends on u2f, which might break #411

Closed
djc opened this issue Jun 1, 2023 · 4 comments
Closed
Labels
dependencies Pull requests that update a dependency file plugin: authenticator

Comments

@djc
Copy link

djc commented Jun 1, 2023

I noticed that tauri-plugin-authenticator recently appeared on crates.io. Is this code actively being developed/used? It depends on the u2f crate, which itself doesn't seem to be getting any more development. I am the lead maintainer for chrono and we're considering making some changes that might break the 0.2 version of the u2f crate. Because tauri-plugin-authenticator recently appeared on crates.io (it looks like this might have been due to #402?) I was worried that this code is being actively developed, but based on this repository's history, it doesn't look like that's the case.

@FabianLars
Copy link
Member

actively developed? No
used? Yes. Plugins for Tauri v1 are only available via git and we were only able to publish v2 plugins really recently as you noticed, so this plugin never popped up on crates.io before.

I'll keep an eye on the u2f PR you guys opened. If it won't get merged, we will think of another way (forking it, pinning chrono, rewriting the plugin, deprecating the plugin, or whatever else) so as far as i am concerned the plugin should not be a blocker for the chrono change.
That said, huge thanks for reaching out to us!!

@djc
Copy link
Author

djc commented Jun 1, 2023

@FabianLars thanks for the prompt response!

@FabianLars FabianLars changed the title tauri-plugin-authenticator depends on u2f, which might break [authenticator] tauri-plugin-authenticator depends on u2f, which might break Aug 16, 2023
@Morgbn
Copy link

Morgbn commented Sep 17, 2023

Hello, any news here?
I'm trying to use the authenticator plugin, but I can't build the app because u2f compilation fails (mismatched types: expected time::Duration, found chrono::Duration)
How to solve the problem? Is there a workaround?

@FabianLars
Copy link
Member

For now it should be enough to add this to the dependencies in your Cargo.toml file

chrono = "<=0.4.29"

We're still a bit unsure what to do with the plugin because we're unhappy with it's current state in general. As a short term solution we may just add that to the readme too. In the longer term we (or someone from the community) can give it the love it deserves and rewrite it, probably using 0.4 of https://crates.io/crates/authenticator

@github-project-automation github-project-automation bot moved this to 📬Proposal in Roadmap Sep 26, 2023
@FabianLars FabianLars added dependencies Pull requests that update a dependency file plugin: authenticator labels Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file plugin: authenticator
Projects
Status: 📬Proposal
Development

No branches or pull requests

3 participants