Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(http): expose proxy configuration #824

Merged
merged 8 commits into from
Dec 20, 2023

Conversation

cijiugechu
Copy link
Contributor

@cijiugechu cijiugechu commented Dec 16, 2023

The fetch method now exposes a proxy field to allow users to configure the proxy for the reqwest client.
Related issues from original repository:

Closes tauri-apps/tauri#6467

@cijiugechu cijiugechu requested a review from a team as a code owner December 16, 2023 10:00
plugins/http/src/commands.rs Outdated Show resolved Hide resolved
plugins/http/src/commands.rs Outdated Show resolved Hide resolved
plugins/http/guest-js/index.ts Outdated Show resolved Hide resolved
plugins/http/src/commands.rs Outdated Show resolved Hide resolved
.changes/http-proxy-config.md Outdated Show resolved Hide resolved
plugins/http/guest-js/index.ts Outdated Show resolved Hide resolved
plugins/http/guest-js/index.ts Outdated Show resolved Hide resolved
plugins/http/src/commands.rs Outdated Show resolved Hide resolved
plugins/http/src/commands.rs Outdated Show resolved Hide resolved
plugins/http/src/commands.rs Outdated Show resolved Hide resolved
@time-river
Copy link

I find wry has been support proxy, therefore I write a simple patch to support it, it's my pull:

Can we merge them to one request?

@cijiugechu
Copy link
Contributor Author

I find wry has been support proxy, therefore I write a simple patch to support it, it's my pull:

Can we merge them to one request?

It seems these two PRs have different use cases, possibly need to let maintainers make the decision.

@FabianLars
Copy link
Member

FabianLars commented Dec 20, 2023

Yeah, 2 different use cases, implementations/targets and repositories. Nothing to merge here :)

Edit: What i meant with that last part is that these 2 PRs should stay seperate and both will be merged into their respective repos.

Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants