Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ReceivedImeText event to ReceivedText #249

Closed
wusyong opened this issue Nov 29, 2021 · 3 comments
Closed

Rename ReceivedImeText event to ReceivedText #249

wusyong opened this issue Nov 29, 2021 · 3 comments
Assignees

Comments

@wusyong
Copy link
Member

wusyong commented Nov 29, 2021

Current ReceivedImeText only pass the string when users use IME. While we could use key event to receive characters if they are not using IME, it will be a mess if we need to handle both inputs with and without IME.
I believe it's better to get an event that can pass the determined text from OS.

cc @lucasfernog and @amrbashir since this will change a bit on Tauri internally

@amrbashir
Copy link
Member

I think we should bring back the old keyboard api and stick with it for a while until winit finishes all of the stuff related to the new keyboard api .

@amrbashir
Copy link
Member

amrbashir commented Nov 30, 2021

Okay I read through winit's new keyboard api issue and turns out that they indeed removed ReceivedCharacter and replaced by KeyEvent.logical_key. more info

they also introduced ReceivedImeText but it is temporary and will be replaced with CompositionEvents but that is still an unfinished api so we use ReceivedImeText until it is finished.

@lucasfernog
Copy link
Member

IIRC tauri doesn't even expose the keyboard APIs right now.

@wusyong wusyong closed this as completed Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants