Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: use standardized keyboard types crate #460

Closed
jkelleyrtp opened this issue Jul 2, 2022 · 2 comments
Closed

Request: use standardized keyboard types crate #460

jkelleyrtp opened this issue Jul 2, 2022 · 2 comments

Comments

@jkelleyrtp
Copy link
Contributor

I'm not sure why, but the Tao codebase has a copy of the keyboard_types::key enum. I'm building a library that uses the actual keyboard_types library and these two enums don't interoperate with each other.

It would be great if Key and Code were taken from a an upstream library so the ecosystem could mesh together better.

@amrbashir
Copy link
Member

amrbashir commented Jul 2, 2022

I think the keyboard types used in tao was a merge of the new-keyboard branch in the upstream crate winit.

Anyhow, We are gonna eventually revert back to depend on winit directly so this issue might be better suited to be discussed with the winit team.

@amrbashir
Copy link
Member

accelerator module is now rewritten using keyboard_types crate in tauri-apps/muda#17 (it will take a while though until it lands in the tauri stack)

global_shortcut module is going to be removed completely and users will need to build their own shortcut manager on top of DeviceEvent::Key

Only keyboard events are left but since we are planning to move back to use winit directly, it is useless to port keyboard events in tao to keyboard_types crate. I opened an issue at winit rust-windowing/winit#2394.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants