-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): add support to setting a webview proxy, closes #4263 #8441
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing!
Apart from the suggested doc change we also need a changefile similar to https://github.com/tauri-apps/tauri/blob/dev/.changes/core-android-proxy-method.md.
Then, i also don't think the explicit example adds much value since it's trying to showcase a single line change.
I would assume people wanting to set up a proxy know how the url should look like. If you don't think so you could add an example to the code doc comment too.
Lastly, we also require all commits to be signed. Here's a guide for that: https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification#ssh-commit-signature-verification - i recommend the ssh approach because i think it's easier. A guide for gpg is right above that though.
Once you set up the code signing you can do git commit --amend && git push --force
to update this PR
b508d76
to
000ac13
Compare
Thanks. I fix the above questions. Is it okay now? |
95b3598
to
ca79e28
Compare
62895db
to
76a36f3
Compare
wry has been supported http/socks5 proxy in [tauri-apps#1006](tauri-apps/wry#1006), which has been merged in [commit 3cc4d79](tauri-apps/wry@3cc4d79). This patch aims to support its feature. Signed-off-by: lin fu <river@vvl.me>
@FabianLars can you review and approve this again? |
Can we have a
|
wry has been supported http/socks5 proxy in #1006, which has been merged in commit 3cc4d79.
This patch aims to support its feature.
Related issues from original repository:
Related pull request