Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rabbitmq, nats and rest as relay services #127

Merged
merged 8 commits into from
Nov 15, 2024
Merged

feat: rabbitmq, nats and rest as relay services #127

merged 8 commits into from
Nov 15, 2024

Conversation

rtkay123
Copy link
Contributor

What did we change?

Added relay services

Why are we doing this?

How was it tested?

  • Locally
  • Development Environment
  • Not needed, changes very basic
  • Husky successfully run
  • Unit tests passing and Documentation done

@rtkay123 rtkay123 requested a review from cshezi November 11, 2024 14:45
@github-actions github-actions bot added the enhancement New feature or request label Nov 11, 2024
cshezi
cshezi reviewed Nov 12, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
src/services/natsRelayService.ts Outdated Show resolved Hide resolved
@cshezi cshezi self-requested a review November 12, 2024 12:57
@rtkay123 rtkay123 marked this pull request as ready for review November 13, 2024 11:04
cshezi
cshezi approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@cshezi cshezi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 LGTM

@rtkay123 rtkay123 merged commit 887aaaa into dev Nov 15, 2024
4 checks passed
@rtkay123 rtkay123 deleted the relay branch November 15, 2024 09:21
@rtkay123 rtkay123 linked an issue Nov 18, 2024 that may be closed by this pull request
Move comms with RabbitMQ, REST to startup-lib #120
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sandy-at-Tazama Sandy-at-Tazama Sandy-at-Tazama approved these changes

@cshezi cshezi cshezi approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move comms with RabbitMQ, REST to startup-lib
3 participants
@rtkay123 @cshezi @Sandy-at-Tazama