Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdTitle for wrapper ad? #34

Open
wroberts15 opened this issue Feb 11, 2015 · 6 comments
Open

AdTitle for wrapper ad? #34

wroberts15 opened this issue Feb 11, 2015 · 6 comments

Comments

@wroberts15
Copy link

Hey just wondering if you think that having the AdTitle in the wrapper ads would be a good addition?

Again, it's just something small I noticed- no AdTitle is generated in a wrapper ad even if specified...

@tbuchok
Copy link
Owner

tbuchok commented Feb 12, 2015

up for a pull request on this? would love to see your contributions to the codebase after all these helpful comments!

@wroberts15
Copy link
Author

Yeah, sounds good to me. Doubt it'll be much, but I'll do that hopefully by tomorrow.

@wroberts15
Copy link
Author

Realized that I may need to make some more changes to this module in the upcoming weeks. Did you want to reject this pull request? It works for me locally, if you did want to include this

@denes16
Copy link

denes16 commented Aug 3, 2021

Is this repo still alive?

@tbuchok
Copy link
Owner

tbuchok commented Aug 5, 2021

hi @denes16 - i haven't put any time into this repo in several years. no longer working in the video world. is there something you're looking for assistance on?

@denes16
Copy link

denes16 commented Aug 5, 2021

hi @denes16 - i haven't put any time into this repo in several years. no longer working in the video world. is there something you're looking for assistance on?

No thanks, but your repo is very useful, and now im using it in a real project, thanks. Its working good, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants