Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use abstract closures for CreateBuiltInFunction #1894

Closed
bakkot opened this issue Mar 10, 2020 · 2 comments · Fixed by #2439
Closed

use abstract closures for CreateBuiltInFunction #1894

bakkot opened this issue Mar 10, 2020 · 2 comments · Fixed by #2439
Labels
editorial change

Comments

@bakkot
Copy link
Contributor

bakkot commented Mar 10, 2020

#1889 introduced a notion of an abstract closure, but we still pass algorithm steps around directly as an argument to CreateBuiltInFunction. It would be nice to replace those with abstract closures too. Plus, the inline style for abstract closures is probably more readable - this would resolve #933.
@ExE-Boss ExE-Boss mentioned this issue Jul 21, 2020
Merged
1 task
@michaelficarra
Copy link
Member

@bakkot Is this fixed by #2109?

@bakkot
Copy link
Contributor Author

bakkot commented Jun 20, 2021

No, there's still a bunch of places we do this. I'm preparing a PR.

@bakkot bakkot mentioned this issue Jun 20, 2021
Merged
@Ms2ger Ms2ger mentioned this issue Sep 22, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
editorial change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Editorial: use abstract closures for anonymous functions in more places tc39/ecma262
2 participants
@michaelficarra @bakkot