Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function.prototype.toString revision #664

Closed
mathiasbynens opened this issue Aug 12, 2016 · 9 comments
Closed

Function.prototype.toString revision #664

mathiasbynens opened this issue Aug 12, 2016 · 9 comments
Labels
proposal This is related to a specific proposal, and will be closed/merged when the proposal reaches stage 4. web reality

Comments

@mathiasbynens
Copy link
Member

https://github.com/tc39/Function-prototype-toString-revision by @michaelficarra

Please tag this issue with the “web reality” label. Thanks!

@domenic
Copy link
Member

domenic commented Aug 15, 2016

Let's leave this open until the proposal has been merged into the main spec, so that people looking at web reality can get a better view.

@domenic domenic reopened this Aug 15, 2016
@littledan
Copy link
Member

I don't think @michaelficarra 's proposal reflects current web reality, as it is not what any particular browser currently ships, as far as I know.

@ljharb
Copy link
Member

ljharb commented Aug 17, 2016

My understanding is that there is a significant percentage that intersects web reality, and for the rest, there isn't cross-browser agreement.

@michaelficarra could you post/point to the data from your presentation about that?

@michaelficarra
Copy link
Member

@ljharb

screen shot 2016-08-18 at 03 22 20

Yeah, I don't think that the Function.prototype.toString proposal differs from web reality. It just makes even stronger guarantees than both what was specified and what exists in implementations.

@michaelficarra
Copy link
Member

By the way, this is why we have stage 3. We're waiting on implementation feedback to confirm that this is both technically feasible and web compatible before moving it to stage 4.

@bakkot
Copy link
Contributor

bakkot commented Aug 18, 2016

fwiw, I believe the proposal disagrees from web reality in its treatment of source text occurring prior to the formal parameters in normal function expressions and declarations.

@michaelficarra
Copy link
Member

@bakkot That's right. I should have said that I believe it is web compatible. So technically different, but not in a way that will break a meaningful number of web pages. But we'll have to wait for implementation feedback (hint, nudge, wink, etc.) before we know this to be true.

@leobalter
Copy link
Member

@bakkot That change makes sense as it places the proposal consistent with it self.

As @ljharb mentioned: "... there is a significant percentage that intersects web reality, ...", which seems reasonable.

@bakkot
Copy link
Contributor

bakkot commented Aug 18, 2016

Sure. Just wanted to clarify that "for the rest, there isn't cross-browser agreement" wasn't quite right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal This is related to a specific proposal, and will be closed/merged when the proposal reaches stage 4. web reality
Projects
None yet
Development

No branches or pull requests

7 participants