Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid underscores in DisplayNames identifiers #646

Closed
sffc opened this issue Jan 13, 2022 · 2 comments
Closed

Forbid underscores in DisplayNames identifiers #646

sffc opened this issue Jan 13, 2022 · 2 comments
Assignees
@FrankYFTang
Labels
c: meta Component: intl-wide issues s: in progress Status: the issue has an active proposal
Milestone
ES 2025

Comments

@sffc
Copy link
Contributor

sffc commented Jan 13, 2022

Follow-up from https://github.com/tc39/ecma402/projects/2#card-68491050

We discussed in the 2022-01-13 meeting whether we should accept underscores in DisplayNames, in response to https://github.com/tc39/test262/pull/3173/files. We decided that we should reject the underscores, and @FrankYFTang is going to follow up with a PR to enforce this in the spec.

Discussion notes: https://github.com/tc39/ecma402/blob/master/meetings/notes-2022-01-13.md#should-we-accept-_-in-identifiers
@sffc sffc added s: in progress Status: the issue has an active proposal c: meta Component: intl-wide issues labels Jan 13, 2022
@sffc sffc added this to the ES 2022 milestone Jan 13, 2022
@FrankYFTang
Copy link
Contributor

PR is already reviewed in #647

@FrankYFTang FrankYFTang mentioned this issue Jan 14, 2022
Merged
@sffc sffc modified the milestones: ES 2022, ES 2023 Jun 1, 2022
@sffc
Copy link
Contributor Author

sffc commented Aug 23, 2023

Confirmed that this appears to have been fixed by #647

@sffc sffc closed this as completed Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FrankYFTang FrankYFTang

Labels
c: meta Component: intl-wide issues s: in progress Status: the issue has an active proposal
Projects
None yet
Milestone
ES 2025
Development

No branches or pull requests
2 participants
@sffc @FrankYFTang