Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip <del> tags when counting number of AO parameters #491

Closed
ptomato opened this issue Oct 17, 2022 · 3 comments · Fixed by #492
Closed

Skip <del> tags when counting number of AO parameters #491

ptomato opened this issue Oct 17, 2022 · 3 comments · Fixed by #492

Comments

@ptomato
Copy link
Contributor

ptomato commented Oct 17, 2022

The parameter counter doesn't handle markup like this very well:

https://github.com/tc39/proposal-temporal/pull/2245/files#diff-cd62efd2602bdd5c2e435179e40c5d2daa5db198c9ac6324a6f8cf1c41a89873R73-R82

It thinks the AO should be called with 4 or 5 parameters, whereas it should be 3 or 4. One of the parameters is inside a <del> tag, hence the discrepancy.

@ptomato
Copy link
Contributor Author

ptomato commented Oct 17, 2022

(A likely-looking workaround is <del>_excludedItems_</del><ins>_excludedKeys_</ins>: a List of property keys,, or _excluded<del>Items</del><ins>Keys</ins>_: ..., but neither of those are accepted by the structured header parser.)

@bakkot
Copy link
Contributor

bakkot commented Oct 17, 2022

Thanks for the report; should be fixed by #492, which I'll publish once it gets through CI.

@bakkot
Copy link
Contributor

bakkot commented Oct 17, 2022

Fixed in 15.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants