This repository has been archived by the owner on Mar 10, 2024. It is now read-only.
Small spec-text fix #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Jan 29, 2018
README.md
Outdated
| @@ -47,7 +47,7 @@ When the SetLastArrayItem method is called, the following steps are taken: | |||
|
|
|||
| Let O be ? ToObject(this value). | |||
| Let len be ? ToLength(? Get(O, "length")). | |||
| If len is zeo, then | |||
| If len is not zero, then | |||
There was a problem hiding this comment.
🤷♂️, how does the rest of the spec handle it? Isn't "zero or positive" implied by ToLength?
There was a problem hiding this comment.
good point. I think it is, but I think that making implications explicit might still be helpful.
- https://tc39.github.io/ecma262/#sec-string.raw uses
<= 0 - https://tc39.github.io/ecma262/#sec-array.prototype.includes uses
is 0 - https://tc39.github.io/ecma262/#sec-array.prototype.indexof uses
is 0 - https://tc39.github.io/ecma262/#sec-array.prototype.lastindexof uses
is 0 - https://tc39.github.io/ecma262/#sec-array.prototype.pop uses
is zero - https://tc39.github.io/ecma262/#sec-array.prototype.reduce uses
is 0 - https://tc39.github.io/ecma262/#sec-array.prototype.reduceright uses
is 0 - https://tc39.github.io/ecma262/#sec-array.prototype.shift uses
is zero
All the other use cases I found were part of a more generic algorithm, like a loop.
Sounds like is 0 is the overarching convention. I'll make a PR to convert the remainder in the spec.
ljharb
approved these changes
Jan 29, 2018
|
Thanks both 👍 ❤️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.