Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming JSON.parsePrimitive instead of parseImmutable #327

Closed
hax opened this issue Jul 19, 2022 · 1 comment
Closed

Naming JSON.parsePrimitive instead of parseImmutable #327

hax opened this issue Jul 19, 2022 · 1 comment

Comments

@hax
Copy link
Member

hax commented Jul 19, 2022

I think "immutable" is more broad, it could also mean immutable objects, people may think JSON.parseImmutable returns deep frozen immutable array/objects. So parsePrimitive may be the more accurate name.

Another reason that I don't like "immutable" in the API name, is it make us impossible to explore the possibility of "mutable" value type (like Swift, Kotlin) in the future.

@rricard
Copy link
Member

rricard commented Jul 25, 2022

That sounds like we'll be able to discuss this in the detached proposal for parseImmutable that we intend to detach in #330.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants