Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal of Record.isRecord & Tuple.isTuple #335

Closed
rricard opened this issue Jul 25, 2022 · 1 comment
Closed

Removal of Record.isRecord & Tuple.isTuple #335

rricard opened this issue Jul 25, 2022 · 1 comment

Comments

@rricard
Copy link
Member

rricard commented Jul 25, 2022

Per #333 - Record.isRecord & Tuple.isTuple should not be checking for wrappers as discussed in plenary.

They are now equivalent as using typeof so they are not useful anymore: we should probably remove them.
@rricard rricard mentioned this issue Jul 25, 2022
Open
25 tasks
@acutmore acutmore mentioned this issue Jul 25, 2022
Merged
@ljharb
Copy link
Member

ljharb commented Jul 25, 2022

While this is fine, do note that because it requires try/catch (which the predicate doesn’t) this necessitates a userland abstraction/package which wasn’t previously necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ljharb @rricard @acutmore