BubbleRelativeDuration: Wrong operator for loop condition

[anba]

Step 8:

Repeat, while unitIndex ≤ largestUnitIndex and done is false,

The loop condition should compare unitIndex ≥ largestUnitIndex instead of unitIndex ≤ largestUnitIndex.

[anba]

Hmm, there are more strange things going on in this operation.

• largestUnit and smallestUnit are both elements from the set {"year", "month", "week", "day"}, cf. asserts in steps 1-2.
• Step 6 initialises unitIndex to the unit index before (!) smallestUnit, so when smallestUnit = "day", then unitIndex is initialised to the index of "week".
• unitIndex is only ever decremented, which means unit must be an element of the set {"year", "month", "week"}.
• But step 8.b.iv handles the case when unit = "day", which doesn't ever occur.

---

And while there, step 3:

3. If smallestUnit is "year", return duration.

Could also be simplified to:

3. If smallestUnit is largestUnit, return duration.

This makes it clearer that no changes will occur when largestUnit is equal to smallestUnit. (When smallestUnit is "year", then largestUnit must be "year", too.)